fix(core)!: $(...).[last,first,all]() defaulting to the first output instead of the output that connects the nodes
#9760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… instead of the output that connects the nodes
despairblue
changed the title
$(...).[last,first,all]() defaulting to the first output instead of the output that connects the nodes$(...).[last,first,all]() defaulting to the first output instead of the output that connects the nodes
n8n-assistant
bot
added
core
krynble
previously approved these changes
Jun 18, 2024
4 flaky tests on run #5580 ↗︎
Details:
|
||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Screenshots
Video
|
|
| NDV > Stop listening for trigger event from NDV |
Screenshots
Video
|
|
10-undo-redo.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Undo/Redo > should undo/redo adding connected nodes |
Test Replay
Screenshots
Video
|
|
30-editor-after-route-changes.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Editor actions should work > after saving a new workflow |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #9760 ↗︎
|
✅ All Cypress E2E specs passed |
ivov
requested changes
Jun 18, 2024
There was a problem hiding this comment.
Thank you for fixing this! If this is a breaking change, let's please update the breaking changes doc as well. Else let's remove ! from the title.
|
Follow-up: https://linear.app/n8n/issue/PAY-1692 |
despairblue
force-pushed
the
pay-1400-bug-last-uses-wrong-branch
branch
from
4f9a2df
to
4f83349
Compare
ivov
reviewed
Jun 18, 2024
ivov
approved these changes
Jun 19, 2024
|
✅ All Cypress E2E specs passed |
adrian-martinez-onestic
pushed a commit
to onesdata/n8n-fork
that referenced
this pull request
Jun 20, 2024
…t instead of the output that connects the nodes (n8n-io#9760)
adrian-martinez-onestic
pushed a commit
to onesdata/n8n-fork
that referenced
this pull request
Jun 20, 2024
…t instead of the output that connects the nodes (n8n-io#9760)
|
Got released with |
1 similar comment
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes
$(...).[last|first|all]()default to the the output the node was connected to.Before it would default to the first output.
Example Workflow
{ "meta": { "templateCredsSetupCompleted": true, "instanceId": "6944c3a4f9d5af1d486eb3bd76ceeae78d947e96a0d9e6c404bb1bcec6a36054" }, "nodes": [ { "parameters": { "path": "e9586c98-e50e-43fb-9c6b-2ff1deaaa0c9", "options": {} }, "id": "669a68fd-cc30-45ff-88f4-6a5455bcf66a", "name": "Webhook1", "type": "n8n-nodes-base.webhook", "typeVersion": 2, "position": [ 180, 700 ], "webhookId": "e9586c98-e50e-43fb-9c6b-2ff1deaaa0c9" }, { "parameters": { "conditions": { "options": { "caseSensitive": true, "leftValue": "", "typeValidation": "strict" }, "conditions": [ { "id": "1fff886f-3d13-4fbf-b0fb-7e2f845937c0", "leftValue": "={{ true }}", "rightValue": "", "operator": { "type": "boolean", "operation": "true", "singleValue": true } } ], "combinator": "and" }, "options": {} }, "id": "588e25bd-940c-498b-91e3-d768f45cc616", "name": "true", "type": "n8n-nodes-base.if", "typeVersion": 2, "position": [ 460, 460 ] }, { "parameters": { "conditions": { "options": { "caseSensitive": true, "leftValue": "", "typeValidation": "strict" }, "conditions": [ { "id": "1fff886f-3d13-4fbf-b0fb-7e2f845937c0", "leftValue": "={{ false }}", "rightValue": "", "operator": { "type": "boolean", "operation": "true", "singleValue": true } } ], "combinator": "and" }, "options": {} }, "id": "dddc1d50-495c-403e-a17a-5305a3b277a8", "name": "false", "type": "n8n-nodes-base.if", "typeVersion": 2, "position": [ 460, 660 ] }, { "parameters": { "conditions": { "options": { "caseSensitive": true, "leftValue": "", "typeValidation": "strict" }, "conditions": [ { "id": "1fff886f-3d13-4fbf-b0fb-7e2f845937c0", "leftValue": "={{ true }}", "rightValue": "", "operator": { "type": "boolean", "operation": "true", "singleValue": true } } ], "combinator": "and" }, "options": {} }, "id": "b794c9be-7d16-47fb-9a5d-d3816c44e247", "name": "false1", "type": "n8n-nodes-base.if", "typeVersion": 2, "position": [ 460, 860 ] }, { "parameters": { "assignments": { "assignments": [ { "id": "41531ffa-e84c-4843-a401-45b93d520f97", "name": "test", "value": "={{ $('false').last().json.code }}", "type": "string" } ] }, "options": {} }, "id": "56928338-14d7-4e70-8979-d091fc8da23e", "name": "Edit fields 2", "type": "n8n-nodes-base.set", "typeVersion": 3.3, "position": [ 840, 660 ] }, { "parameters": { "assignments": { "assignments": [ { "id": "41531ffa-e84c-4843-a401-45b93d520f97", "name": "test", "value": "={{ $('true').last().json.code }}", "type": "string" } ] }, "options": {} }, "id": "c71938b7-fe93-4a6a-8c90-10ef02f1d56f", "name": "Edit fields 1", "type": "n8n-nodes-base.set", "typeVersion": 3.3, "position": [ 840, 460 ] }, { "parameters": { "assignments": { "assignments": [ { "id": "41531ffa-e84c-4843-a401-45b93d520f97", "name": "test", "value": "={{ $('false1').last().json.code }}", "type": "string" } ] }, "options": {} }, "id": "aab4f1c7-465b-474b-b769-4afd10232f1a", "name": "Edit fields 3", "type": "n8n-nodes-base.set", "typeVersion": 3.3, "position": [ 840, 860 ] } ], "connections": { "Webhook1": { "main": [ [ { "node": "true", "type": "main", "index": 0 }, { "node": "false", "type": "main", "index": 0 }, { "node": "false1", "type": "main", "index": 0 }, { "node": "Edit fields 3", "type": "main", "index": 0 } ] ] }, "true": { "main": [ [ { "node": "Edit fields 1", "type": "main", "index": 0 } ] ] }, "false": { "main": [ null, [ { "node": "Edit fields 2", "type": "main", "index": 0 } ] ] }, "false1": { "main": [ null, [ { "node": "Edit fields 3", "type": "main", "index": 0 } ] ] } }, "pinData": { "Webhook1": [ { "name": "First item", "code": 1 }, { "name": "Second item", "code": 2 } ] } }Before it would always evaluate output 0 (true branch)
Now it will take the output that connects the nodes. If the user wants another output they'd have to specify if like
$(...).last(1)Workflows that rely on something like the third example will break with this change.
Workflows that rely on
last,firstandallalways returning the first output will also break.The ticket is marked as a bug, meaning this was never the intended behavior. I marked this as a breaking change regardless.
We'd also want to update the docs to make it clear how those functions work: https://docs.n8n.io/code/builtin/output-other-nodes/
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/PAY-1400/bug-dollarlast-uses-wrong-branch
n8n-io/n8n-docs#2167
Review / Merge checklist
PR Labeled withrelease/backport(if the PR is an urgent fix that needs to be backported)