Embed JSON subtitles as Matroska attachments #9991
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests run fine on my machine but the CI complains about a self signed certificate for the proxy tests, not sure what to do here :/ |
|
Rebased. Hopefully tests will pass now, as I'm seeing some changes to Update: They did! |
The old stream index specifiers would indiscriminately select any JSON attachment, which made stuff like embedding live chat json data risky if not impossible. Also adds `-copy_unknown` as JSON data is "unknown" according to FFmpeg (since it has no codec id) and thus would otherwise be rejected by default.
Since we can't embed them as regular subtitles (due to them not having any consistent structure), we embed them as file attachments, if exporting as Matroska. This allows us to have single-file downloads with everything embedded for e.g. archival purposes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
The
--embed-subsoption currently skips JSON files, such as Youtube's live chat data, as they have no standard structure and FFmpeg complains. This is a bit of a bummer as, to my best knowledge, they're the last hurdle left for single-file downloads, which I use for my archives.This PR allows them to be embedded as regular attachments if using
mkv/mkafiles, aided by the use of metadata stream specifiers1. These kind specifiers allow to be more precise and simplify the logic as we don't have to guess the stream number.It also includes an improvement for the metadata post processor by using this stream selector type so that we don't accidentally override other JSON data (such as JSON subs) when embedding the info JSON.
Fixes #9957.
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?
Footnotes
m:key[:value], see https://ffmpeg.org//ffmpeg.html#toc-Stream-specifiers-1 . ↩