Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nrk] Add chapter and login support #10187

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MrDemocracy
Copy link

@MrDemocracy MrDemocracy commented Jun 15, 2024

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

Adds support for downloading in the EU using the --username and --password (optional) parameters. Also implemented chapters extraction. It extracts the "intro end" and "skip credits" markers too. Additionally, the timestamp now uses the oldest value from either "publication date", "available from" or the previously used "timestamp" value.

Finally, cleaned up the code slightly by removing a seemingly unnecessary function and changed the extractor to no longer skip encrypted streams as unencrypted streams are not always available. These final changes seem to have fixed the two other open issues for this extractor.

Fixes

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

@seproDev seproDev added the site-enhancement Feature request for some website label Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-enhancement Feature request for some website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants