[nrk] Add chapter and login support #10187
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
Adds support for downloading in the EU using the
--username
and--password
(optional) parameters. Also implemented chapters extraction. It extracts the "intro end" and "skip credits" markers too. Additionally, the timestamp now uses the oldest value from either "publication date", "available from" or the previously used "timestamp" value.Finally, cleaned up the code slightly by removing a seemingly unnecessary function and changed the extractor to no longer skip encrypted streams as unencrypted streams are not always available. These final changes seem to have fixed the two other open issues for this extractor.
Fixes
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?