[ie/zaiko] Add support jwt-protected video urls #10130
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bashonly
requested changes
Jun 17, 2024
Comment on lines
+86
to
+89
| stream_url = self._download_json(traverse_obj( | ||
| initial_event_info, ('jwt_token_url', {url_or_none})), video_id, | ||
| note='Downloading jwt-protected stream url', | ||
| errnote='Failed to download jwt-protected stream url')['playback_url'] |
There was a problem hiding this comment.
don't need the traversal here if it's otherwise fatal
Suggested change
| stream_url = self._download_json(traverse_obj( | |
| initial_event_info, ('jwt_token_url', {url_or_none})), video_id, | |
| note='Downloading jwt-protected stream url', | |
| errnote='Failed to download jwt-protected stream url')['playback_url'] | |
| stream_url = self._download_json( | |
| initial_event_info['jwt_token_url'], video_id, 'Downloading JWT-protected stream URL', | |
| 'Failed to download JWT-protected stream URL')['playback_url'] |
| @@ -66,7 +66,9 @@ def _real_extract(self, url): | |||
| stream_meta['stream-access']['video_source'], video_id, | |||
| 'Downloading player page', headers={'referer': 'https://zaiko.io/'}) | |||
| player_meta = self._parse_vue_element_attr('player', player_page, video_id) | |||
| status = traverse_obj(player_meta, ('initial_event_info', 'status', {str})) | |||
| initial_event_info = player_meta['initial_event_info'] | |||
There was a problem hiding this comment.
The rest of the extractor seemed to be written to be non-fatal all the way down to the expected raise_no_formats call. Will making this line fatal have any ill effect? (I'm just asking a question, not requesting a change here)
There was a problem hiding this comment.
Will making this line fatal have any ill effect?
Well, I didn't check it carefully. Not all information is extracted from the "initial_event_info" object (we also have "player_meta"), so making it fatal is not ideal.
The design of "fatal vs. non-fatal" always confuses me, btw.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
Credit goes to @vschule (see #9798 (comment)). I wrote this PR based on their informative suggestion.
This PR fixes #9798 .
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?