[ie/crunchyroll:show] Implement language filter extractor arg #10067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
bashonly
approved these changes
May 30, 2024
| @@ -1791,6 +1791,9 @@ The following extractors use this feature: | |||
| #### crunchyrollbeta (Crunchyroll) | |||
| * `hardsub`: One or more hardsub versions to extract (in order of preference), or `all` (default: `None` = no hardsubs will be extracted), e.g. `crunchyrollbeta:hardsub=en-US,de-DE` | |||
|
|
|||
| #### crunchyrollbetashow (Crunchyroll) | |||
| * `language`: The language variants to extract, or `all` (default: `all`) | |||
There was a problem hiding this comment.
maybe add an example like above?
Suggested change
| * `language`: The language variants to extract, or `all` (default: `all`) | |
| * `language`: The language variants to extract, or `all` (default: `all`), e.g. `crunchyrollbetashow:language=en-US,de-DE` |
bashonly
added
site-request
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
Speedup for language selection (
--match-filters language=ja-JP=>--extractor-args crunchyrollbetashow:language=ja-jp) as per #9867 (comment).Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?