Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Added environment.yml in CI #515

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

shark-21
Copy link
Contributor

What do these changes do?

Adds environment.yml

Related issue number

Fixes #329

@XprobeBot XprobeBot added this to the v0.3.2 milestone Jun 11, 2023
@codecov
Copy link

codecov bot commented Jun 11, 2023

Codecov Report

Merging #515 (33f28ae) into main (8e96864) will decrease coverage by 3.86%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #515      +/-   ##
==========================================
- Coverage   67.90%   64.04%   -3.86%     
==========================================
  Files        1001     1001              
  Lines       77649    77649              
  Branches    16135    16135              
==========================================
- Hits        52727    49731    -2996     
- Misses      22790    25860    +3070     
+ Partials     2132     2058      -74     
Flag Coverage Δ
unittests 64.00% <ø> (-3.83%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 152 files with indirect coverage changes

@UranusSeven
Copy link
Contributor

Thanks for your contribution!

Since we have updated the dev documentation, and replace the mamba section with conda, I think an environmental.yml is not necessary.

What do you think?

@shark-21
Copy link
Contributor Author

shark-21 commented Jun 12, 2023

Yeah sure. I thought environment.yml file may be needed for the upcoming slurm deployment project also it might be convenient to add changes in the dependencies.

@UranusSeven
Copy link
Contributor

Yeah sure. I thought environment.yml file may be needed for the upcoming slurm deployment project also it might be convenient to add changes in the dependencies.

To my understanding, conda is also available for slurm environments.

Is that correct? @luweizheng @ChengjieLi28

@luweizheng
Copy link
Contributor

slurm environments

Do not get what you want to say.
I think this PR does not affect SLURM deployment.
As on a SLURM cluster, users can install what they want into a environment by using venv conda or any other env management tools.
This PR only adds an environment.yml file required by contributors who want to build a local dev environment.

@shark-21 shark-21 changed the title Added environment.yml in CI DOC: Added environment.yml in CI Jun 13, 2023
@XprobeBot XprobeBot added the documentation Improvements or additions to documentation label Jun 13, 2023
@shark-21
Copy link
Contributor Author

So should issue #329 be closed ? or what else can I do ?

@XprobeBot XprobeBot modified the milestones: v0.3.2, v0.4.1 Jul 1, 2023
@XprobeBot XprobeBot modified the milestones: v0.4.1, Temp Jul 10, 2023
@aresnow1 aresnow1 removed this from the Temp milestone Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: development guide needs updates
5 participants