feat(frontend): Add context for inner components of list, groups and … #3974
Conversation
Deploying windmill with
|
| Latest commit: |
057c0da
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://700ca92d.windmill.pages.dev |
| Branch Preview URL: | https://fr-add-missing-context.windmill.pages.dev |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to e7779d0 in 1 minute and 26 seconds
More details
- Looked at
84lines of code in2files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_vyzffLo6n9hHPWet
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
frontend/src/lib/components/apps/editor/settingsPanel/ContextVariables.svelte
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 5347f2c in 1 minute and 43 seconds
More details
- Looked at
77lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_q2Idr2L9XwPKoXhR
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
❌ Changes requested. Incremental review on d2e00e7 in 1 minute and 36 seconds
More details
- Looked at
126lines of code in2files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_F6qQGkVqrEkTMehS
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
frontend/src/lib/components/apps/editor/settingsPanel/ContextVariables.svelte
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
❌ Changes requested. Incremental review on bbb3eb8 in 1 minute and 59 seconds
More details
- Looked at
44lines of code in2files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_z1IXQuQKw03q5x0s
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
frontend/src/lib/components/apps/editor/settingsPanel/ContextVariables.svelte
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
❌ Changes requested. Incremental review on 40ac35c in 1 minute and 17 seconds
More details
- Looked at
22lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_etx26Nf63bMAruid
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
frontend/src/lib/components/apps/editor/settingsPanel/ContextVariables.svelte
Show resolved
Hide resolved
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on d3f56c3 in 1 minute and 24 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. frontend/src/lib/components/apps/editor/settingsPanel/ContextVariables.svelte:57
- Draft comment:
The removal of unnecessary optional chaining inparentId.split('-')[0]is a good simplification sinceparentIdis already checked for truthiness. This makes the code cleaner and more efficient. - Reason this comment was not posted:
Confidence changes required:33%
The PR modifies theprocessParentsfunction, specifically the line whereparentIdis parsed. The change removes unnecessary optional chaining sinceparentIdis already checked for truthiness in the line above. This is a minor cleanup that simplifies the code and removes redundant checks.
Workflow ID: wflow_XMtbQEetfhpOViSd
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 8116e30 in 1 minute and 50 seconds
More details
- Looked at
66lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. frontend/src/lib/components/apps/editor/settingsPanel/ContextVariables.svelte:72
- Draft comment:
Consider moving the call tofindParentsContextVariables(id)inside anonMountlifecycle function to ensure that all component properties are fully initialized before this function is executed. This can prevent potential issues with uninitialized or changing properties during component setup. - Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_9nip3J0r4ggW4Fwu
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
…labs/windmill into fr/add-missing-context
Add missing contexts table actions and sub components
…tables
Summary:
Enhanced handling of context variables in the settings panel, including updates to logic and the introduction of a function to prevent duplicates, along with the removal of an outdated function.
Key points:
frontend/src/lib/components/apps/editor/settingsPanel/ContextVariables.svelteaddContextVariablefunction to avoid duplicate entriescontainercomponent,listcomponent, and various table-related componentsfindEveryParentGridItemfunction fromfrontend/src/lib/components/apps/editor/appUtils.tsGenerated with ❤️ by ellipsis.dev