Fix !important parsing for yet more CSS properties. #46894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5651125
branch
from
3ea1e5d
to
552c69a
Compare
These are discovered by running through the entire test suite in a mode where every successful value parse is re-tried with “ !important” added at the end, and then picking out the relevant failures. (There are some cases with e.g. unbalanced parentheses which are false positives.) Fixed: 348442541 Change-Id: Ib2444d64575a32fa21a427a3c3112fa5519de3c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5651125 Reviewed-by: Anders Hartvoll Ruud <[email protected]> Commit-Queue: Steinar H Gunderson <[email protected]> Cr-Commit-Position: refs/heads/main@{#1319651}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5651125
branch
from
552c69a
to
7f09f35
Compare
wpt-pr-bot
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are discovered by running through the entire test suite in a mode
where every successful value parse is re-tried with “ !important” added
at the end, and then picking out the relevant failures. (There are some
cases with e.g. unbalanced parentheses which are false positives.)
Fixed: 348442541
Change-Id: Ib2444d64575a32fa21a427a3c3112fa5519de3c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5651125
Reviewed-by: Anders Hartvoll Ruud <[email protected]>
Commit-Queue: Steinar H Gunderson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1319651}