Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Named vector multi search #5099

Merged
merged 73 commits into from
Jun 17, 2024
Merged

Named vector multi search #5099

merged 73 commits into from
Jun 17, 2024

Conversation

dirkkul
Copy link
Contributor

@dirkkul dirkkul commented Jun 7, 2024

What's being changed:

Superseeds #4955
First part of #5138

Adds multi target support to all vector searchs (nearXXX + hybrid).

This flow is the following:

  • Users can provide multiple target vectors
  • Each target vector is searched concurrently.
  • The results of different target vectors will contain different objects, which makes it hard to combine things
    • Missing distances will be computed. This requires a new remote endpoint as some objects have to be fetched from other nodes. This happens concurrently.
  • Combinations happens when all distances are ready

To run the python integration tests use ./test/run.sh --acceptance-only-python or install the latest client using pip install git+https://github.com/weaviate/weaviate-python-client.git@named_vector_multi_search

GQL support for different combination methods is still missing - I will add that later in a separate PR

Review checklist

  • Documentation has been updated, if necessary. Link to changed documentation:
  • Chaos pipeline run or not necessary. Link to pipeline:
  • All new code is covered by tests where it is reasonable.
  • Performance tests have been run or not necessary

cluster/store_apply.go Outdated Show resolved Hide resolved
entities/schema/config/vector_index_config.go Outdated Show resolved Hide resolved
entities/schema/config/vector_index_config.go Show resolved Hide resolved
usecases/sharding/remote_index.go Show resolved Hide resolved
adapters/repos/db/vector/flat/index.go Show resolved Hide resolved
Copy link

sonarcloud bot commented Jun 17, 2024

Quality Gate Passed Quality Gate passed

Issues
21 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
2.5% Duplication on New Code

See analysis details on SonarCloud

@antas-marcin antas-marcin merged commit fbda19b into main Jun 17, 2024
40 of 42 checks passed
@antas-marcin antas-marcin deleted the named_vector_multi_search2 branch June 17, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants