Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nit: Fix function comments that don't start w func name #5026

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DataDavD
Copy link

@DataDavD DataDavD commented May 27, 2024

Refactor function comments for go doc.

Note: I got bored and did this since it kinda annoyed me when working on another PR, so feel free to ignore and close this PR if y'a want.

Copy link

sonarcloud bot commented May 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@reyreaud-l
Copy link
Contributor

reyreaud-l commented May 29, 2024

Thanks a lot for these changes, it's something we're looking at getting better at. Not all the comment are perfect but they'll get picked up by GoDoc and that's already a good first step. Thanks!

@reyreaud-l reyreaud-l self-requested a review May 29, 2024 07:15
@reyreaud-l
Copy link
Contributor

One thing before we can merge your work (We should have a bot asking for this but it didn't trigger ?) Do you accept our contribution agreement & guidelines ? See here https://github.com/weaviate/weaviate/blob/main/CONTRIBUTING.md#agreements.

Please explicitly state in this PR that you agree with it and we can merge your work :)

@antas-marcin
Copy link
Contributor

@DataDavD Simply stating in comment "I agree with CLA" will enable us to merge your PR

@DataDavD
Copy link
Author

Hey friends, sorry for the response. Happy to help in any form.

I agree with CLA

@DataDavD
Copy link
Author

hey friends, sorry for the bump, just wondering if y'all saw the PR should be good now.

cheers

@DataDavD
Copy link
Author

hey sorry, just bumping this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants