Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove commented out method in repos/sorter package #5011

Merged
merged 1 commit into from
Jun 24, 2024
Merged

chore: remove commented out method in repos/sorter package #5011

merged 1 commit into from
Jun 24, 2024

Conversation

kumarlokesh
Copy link
Contributor

What's being changed:

Found method createFromObject to be commented out, and
not having any references to it in the current codebase.

Review checklist

  • Documentation has been updated, if necessary. Link to changed documentation:
  • Chaos pipeline run or not necessary. Link to pipeline:
  • All new code is covered by tests where it is reasonable.
  • Performance tests have been run or not necessary.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 3, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
5.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@dirkkul dirkkul enabled auto-merge June 24, 2024 13:24
auto-merge was automatically disabled June 24, 2024 13:35

Head branch was pushed to by a user without write access

@dirkkul dirkkul merged commit 4c44e94 into weaviate:main Jun 24, 2024
37 of 38 checks passed
@kumarlokesh kumarlokesh deleted the patch-2 branch June 24, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirkkul dirkkul dirkkul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kumarlokesh @dirkkul