test(v6): add runner dynamic import test #17422
Conversation
|
|
| @@ -17,3 +19,27 @@ describe('resolveBuildEnvironmentOptions in dev', () => { | |||
| expect(config.build.rollupOptions).not.toHaveProperty('input') | |||
| }) | |||
| }) | |||
|
|
|||
| test('runner dynamic import', async () => { | |||
There was a problem hiding this comment.
There is a test for dynamic import already: https://github.com/vitejs/vite/blob/v6/environment-api/packages/vite/src/node/ssr/runtime/__tests__/fixtures/dynamic-import.js
I would rather we update it there
There was a problem hiding this comment.
Thanks for the pointer. Moving there makes sense 👍
The same issue reproduces there, but I'm seeing a weird error like it shows up on annotation:
PrettyFormatPluginError: [module runner] Dynamic access of "import.meta.env" is not supported. Please, use "import.meta.env.$$typeof" instead.
Locally, I confirmed the reproduction by console.log like this:
console.log(modules.static === modules.dynamicAbsoluteExtension); // true
console.log(modules.static === modules.dynamicAbsoluteFull); // falseThere was a problem hiding this comment.
This is because there is a test file that does export const meta = import.meta, and accessing .env causes it to throw an error (the Vitest equality checker/formatter tries to access $$typeof)
There was a problem hiding this comment.
Oh right I remember. For now I changed it to expect(modules.static === modules.dynamicAbsoluteFull).toBe(true) so that the error is not confusing.
Description
I'm testing alpha.18 hi-ogawa/vite-environment-examples#91 and found that
import(/* @vite-ignore */ someAboslutePath)is returning a duplicate module. I added a failing test case in this PR.