Tiles traverser: do not check for visibility in canTraverse
.
#3032
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Yet another fix for tile traversal. Bug was noticed while traveling in Google's 3D Tiles.
The
canTraverse
function should not check for visibility in the traversal process, as shown in the CesiumJS code. Probably there are cases where a parent in the traversal process is not visible, but the child tile is.Here is how it looked before the fix:
And here is how it looks after:
Possibly, this functionality existed previously via the
ignoreVisibility
argument. Now I removed both optional arguments fromcanTraverse
since they are not used.If approved, would it be possible to merge this PR to the current stable branch?
Thank you,
/Avner