Add support for Node 16 (LTS) #199
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/vercel/og-image/DMa5qoBKz89XVguUZ7vS74cEb6e3 |
marcofranssen
force-pushed
the
support-node16
branch
from
40e6096
to
c6cf577
Compare
There was a problem hiding this comment.
This needs to be deployed with 14.x at this time since chrome-aws-lambda doesn't support 16.x
See the upstream PR alixaxel/chrome-aws-lambda#274
|
On my local environment I'm able to run it with Node 16, is there a way to support this locally with Node 16, but still enforce Node 14 for the AWS parts? |
|
If its working fine locally, why does the config need to change? |
Otherwise it just errors with a message Node 14 is required. |
|
What is the error? Can you use |
See below the error and tryout of $ yarn build --ignore-engines
yarn run v1.22.18
error @: The engine "node" is incompatible with this module. Expected version "14.x". Got "16.14.2"
error Commands cannot run with an incompatible environment.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
$ vercel dev --ignore-engines
Vercel CLI 24.0.0
Error! unknown or unexpected option: --ignore-engines
$ vercel dev
Vercel CLI 24.0.0
> Creating initial build
Running "yarn run build"
yarn run v1.22.18
error @: The engine "node" is incompatible with this module. Expected version "14.x". Got "16.14.2"
error Commands cannot run with an incompatible environment.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Error! Command "yarn run build" exited with 1 |
|
It works with |
|
Is it OK to add that as a fix in this PR? Otherwise I'm still stuck with the fact I can't use it out of the box. I either have to change the supported node version or I have to change this build script. |
|
To make it work locally. Otherwise you get the error only node 14 is supported
Get Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: Steven ***@***.***>
Sent: Monday, March 14, 2022 3:32:47 PM
To: vercel/og-image ***@***.***>
Cc: Marco Franssen ***@***.***>; Author ***@***.***>
Subject: Re: [vercel/og-image] Add support for Node 16 (LTS) (PR #199)
If its working fine locally, why does the config need to change?
—
Reply to this email directly, view it on GitHub<#199 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAFJTTKMA2VZ4EGQ2ERSPDDU75EY7ANCNFSM5QPOU3GQ>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
Closing in favor of #226 |
No description provided.