Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/variables highlighting #2502

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

lohxt1
Copy link
Collaborator

@lohxt1 lohxt1 commented Jun 21, 2024

Description

~ only highlight path params pattern in request url bar
~ fix js highlighting in scripts
~ changed 'combinedmode' to 'brunovariables'

before after

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

@pietrygamat
Copy link
Contributor

pietrygamat commented Jun 21, 2024

This is a problem on main as well as in this branch, but since you started working on fixing variables highlighting, I'll let myself report it here: mind what you consider a path parameter. The coloring is a bit to greedy - not all : in a URL is a start of parameter word:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants