Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when attempting to "generate code" of a request #2501

Merged

Conversation

JeanLethiec
Copy link
Contributor

@JeanLethiec JeanLethiec commented Jun 21, 2024

Description

Closes #2444

When generating code for a request, getEnvironmentVariables() of CodeEditor was called with an undefined value, because props of CodeEditor did not contain "collection" in the specific case of being instantiated from CodeView.
I've added this collection var when creating the CodeEditor in CodeView.

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

@jwetzell
Copy link
Contributor

@sanjai0py

@helloanoop helloanoop merged commit fd57b2c into usebruno:main Jun 28, 2024
@helloanoop
Copy link
Contributor

Thanks for fixing the bug @JeanLethiec !

@mstaal
Copy link

mstaal commented Jun 28, 2024

Nice! When will you ship a new release containing this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error attempying to Generate Code
4 participants