fix: invalid json body mistakenly quoted #2449
Open
+16
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yes,you are right,please merge this request as soon as possible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses the issue #2043.
It is also related to this one axios/axios#4034
In my opinion, Bruno shouldn't patch a faulty JSON string, since it restrains its range of use, notably when working with poorly designed APIs.
Moreover, other API clients (Postman, insomnia) don't have this behavior, so it could prevent one from adopting Postman.
The fix consists in adding a transformRequest to the Axios instance that prevents the default behavior if the content type is "application/json" and the body is a string.