-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] : Settings on folder level #1334
[Feature] : Settings on folder level #1334
Conversation
… using folder.bru
…ers, ignore folder.bru file il requests list
…ing network request
It would be nice to have body and tests also.. |
@fulvio-diller Yeah i'll add those once headers are validated and officially stable |
A thought from a design perspective: Should the concept of "Folders" be removed and should "Collections" be able to be nested? I'm not sure if that has already been discussed but it seems like that is the desired functionality as expressed in #1174 & #1310 Personally, my team would greatly benefit from being able to nest Collections to run a hierarchy of tests. So much so, that if we had that functionality, we would swap from Postman to Bruno immediately. |
Hi @kyleboe, I do not think that nesting collections is a good idea for several reasons:
To my understanding the concept of folder exist to create hierarchical tests. Therefore I want to be able to store scripts, tests ... at folder level. Kind Regards |
} | ||
const directories = pathname | ||
.substring(parameterIndex + parameter.length, filenameIndex) | ||
.split('/') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PATH_SEPERATOR
should be used here and 5 lines below for Windows compatible
} | ||
return acc; | ||
}, {}); | ||
const mergeParams = mergeRequests(collectionCopy.root.request, folderDatas); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For new collection collectionCopy.root
can be undefined resulting in an error here.
c1a57d3
into
usebruno:feat/folder-level-settings
Merged to |
Description
Referencing issue #1310
Add settings at the folder level similarly to collection settings
Contribution Checklist:
Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.
Publishing to New Package Managers
Please see here for more information.