-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upstream extension-search-path.patch #2753
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same considerations as voiced in nix issue tracker.
Besides, this patch does not apply.
I avoided the nixpkgs issue largely because of its slightly convoluted history. Given that I both maintain ungoogled-chromium and it's nixpkgs packaging (CC @emilylange), I'll try to take a closer look (can't promise when) at declarative extensions and whether ungoogled-chromium should put patches for it into its patchset |
One of the stated goals of the
As this is a patch that enhances control, I'd argue this patch does apply. |
that is a technical observation:
|
Sorry! Misinterpreted your statement. |
The patch should apply now. |
@networkException Have you had a chance to glance through? What's your opinion? |
with my nixpkgs chromium maintainer hat on I don't see the patch as useful here or in packaging as there are ways not needing modifications which I would prefer anyways |
I would love to see this in UC. It's not just for including extensions from chromestore, but also for developing your own.
|
Just fixed a merge conflict. Would anyone from UC be willing to review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this is not happening until it gets decided in nixpkgs upstream.
In what way is nixpkgs to be considered upstream to this? What decision should be taken by nixpkgs and how would it influence UC? EDIT: As per new feature criteria, would it help if the extension search path could be set in chrome://flags? EDIT2: I hope you don't mind, I created #2932 for discussing this in more depth. I considered putting that in a gist as well as on nixos discourse. An issue in this repo seemed most appropriate to me. |
I have also sent this patch to chromium upstream. It can be tracked here: https://chromium-review.googlesource.com/c/chromium/+/5650013 |
Upstreams the extension search path patch from NixOS/nixpkgs#188086