chore: upgrade resource-server from 1.3.1 to 1.4.0 #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjagg
requested review from
jonathanmtran,
asgrant,
jimhelwig,
cousquer,
jgribonvald,
amgoodfellow and
cbeach47
jgribonvald
approved these changes
Jan 21, 2022
| @@ -18,7 +18,7 @@ notificationPortletVersion=4.7.3 | |||
| # Required for very old front-end dependencies | |||
| resourceServerVersion=1.0.48 | |||
| # Includes newer front-end dependencies and web components | |||
| resourceServer13Version=1.3.1 | |||
| resourceServer13Version=1.4.0 | |||
There was a problem hiding this comment.
Mhhh why the name of the property contains 13 ? Shouldn't be an other name to distinguish ?
There was a problem hiding this comment.
1.3 is the version that introduced WebJars support, so 1.3 became 13. I agree, It should be updated at some point.
There was a problem hiding this comment.
I've tested with the 1.4.1 version of the resource server, and it seems good. I didn't deployed on production
jonathanmtran
approved these changes
Jan 26, 2022
ChristianMurphy
approved these changes
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of change
Upgrade Resource Server to v1.4.0