Skip to content
This repository has been archived by the owner on Feb 1, 2022. It is now read-only.

Added options to configure number of grid cols and screen names #391

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

freezy-sk
Copy link
Contributor

Added options to configure number of grid cols and screen names through options param.
Fixes various false positives when linting custom built bootstrap.

…gh options param. Fixes various false positives when linting custom built bootstrap.
.travis.yml Outdated
@@ -7,7 +7,8 @@
"rvm install 2.2",
"rvm use 2.2 --fuzzy",
"export GEMDIR=$(rvm gemdir)",
"echo \"ruby=$(basename $GEMDIR) jekyll=$JEKYLL_VERSION\" > pseudo_Gemfile.lock"
"echo \"ruby=$(basename $GEMDIR) jekyll=$JEKYLL_VERSION\" > pseudo_Gemfile.lock",
"npm install -g [email protected]"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is unrelated change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know, but it was necessary to get tests running

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made it as separate PR #393 so after accepting that, I will remove these lines

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like that approach, we should just get rid of custom caching and stuff like I did with Bootstrap.

twbs/bootstrap@4265f86

And it seems I already have #363 so I'm gonna look at it when I have some time.

…gh options param. Fixes various false positives when linting custom built bootstrap.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants