Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support HTTP basicAuth for docker and swarm endpoint #10776

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

985492783
Copy link

@985492783 985492783 commented Jun 1, 2024

What does this PR do?

  1. Add docker and swarm BasicAuth

Motivation

To fix #10757 to support HTTP BasicAuth for docker and swarm.

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

@ldez ldez changed the title [Feature] Support Http basicAuth for docker and swarm Support Http basicAuth for docker and swarm endpoint Jun 2, 2024
@nmengin
Copy link
Contributor

nmengin commented Jun 3, 2024

Hello @985492783,

Thank you for this contribution.
We've set the design-review label to check is we agree with the implementation before reviewing it.

We'll update the label as soon as we check it.

@kevinpollet kevinpollet changed the title Support Http basicAuth for docker and swarm endpoint Support HTTP basicAuth for docker and swarm endpoint Jun 5, 2024
@kevinpollet kevinpollet added this to the next milestone Jun 20, 2024
Copy link
Contributor

@jspdown jspdown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @985492783 for opening this PR.

I think that what you've done is the right approach to providing BasicAuth on this provider.

Initially I thought that maybe we could directly put the username/password in the endpoint field. But after more consideration I think it would bring some confusion, especially for the tcp scheme.

Although, to simplify the use of this feature, I think it would be best to have 2 configuration fields instead of basicAuth:

  • username
  • password

@985492783
Copy link
Author

Thanks @985492783 for opening this PR.

I think that what you've done is the right approach to providing BasicAuth on this provider.

Initially I thought that maybe we could directly put the username/password in the endpoint field. But after more consideration I think it would bring some confusion, especially for the tcp scheme.

Although, to simplify the use of this feature, I think it would be best to have 2 configuration fields instead of basicAuth:

  • username
  • password

get

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

To support HTTP Basic authentication for docker/swarm provider's endpoint
5 participants