Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support systemd socket-activation #10399

Merged
merged 4 commits into from
Jun 25, 2024
Merged

Support systemd socket-activation #10399

merged 4 commits into from
Jun 25, 2024
+91 −20

Conversation

juliens
Copy link
Member

@juliens juliens commented Jan 31, 2024

What does this PR do?

This PR adds the support for systemd socket activation.

Motivation

Fixes #9891

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

Co-authored-by: Michael [email protected]

@juliens juliens added this to the 3.0 milestone Jan 31, 2024
@mmatur mmatur added the kind/enhancement a new or improved feature. label Jan 31, 2024
@juliens juliens force-pushed the socket-activation-poc branch 2 times, most recently from bde1f6b to 7386d41 Compare January 31, 2024 16:58
@nmengin nmengin added the priority/P2 need to be fixed in the future label Feb 1, 2024
@mloiseleur
Copy link
Contributor

I tested this PR.
It works like a charm !

@yznerf yznerf mentioned this pull request Feb 11, 2024
Closed
nmengin
nmengin approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@juliens juliens changed the base branch from v3.0 to master February 22, 2024 14:45
@juliens juliens modified the milestones: 3.0, next Feb 22, 2024
@johnnypea
Copy link

Do you have any plans to release this soon? Thanks

@rtribotte
Copy link
Member

Hello @johnnypea,

Thanks for your interest in Traefik!
The plan is to bring this feature in the next minor version (v3.1.0)!

@eriksjolund
Copy link

Side note:

I wanted to learn how to use this new functionality with rootless Podman and quadlet unit files,
so I built a traefik container image (arm64) from the latest git commit from
https://github.com/juliens/traefik/tree/socket-activation-poc
(git commit 6d15f00)

I then created a minimal example where a traefik container is acting as an HTTP reverse proxy in front of an nginx container. It seems to work just fine.
For details, see
https://github.com/eriksjolund/podman-traefik-socket-activation/

@rtribotte rtribotte self-assigned this Jun 24, 2024
@kevinpollet kevinpollet changed the title Adds systemd socket-activation feature Support systemd socket-activation Jun 25, 2024
kevinpollet
kevinpollet approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@kevinpollet kevinpollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rtribotte rtribotte removed their assignment Jun 25, 2024
@traefiker traefiker merged commit b7de043 into traefik:master Jun 25, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinpollet kevinpollet kevinpollet approved these changes

@nmengin nmengin nmengin approved these changes

@rtribotte rtribotte rtribotte approved these changes

Assignees
No one assigned
Labels
area/server kind/enhancement a new or improved feature. priority/P2 need to be fixed in the future size/S
Projects
None yet
Milestone
next
Development

Successfully merging this pull request may close these issues.

Add systemd socket activation support
9 participants
@juliens @mloiseleur @johnnypea @rtribotte @eriksjolund @kevinpollet @nmengin @mmatur @traefiker