-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error message and documentation on the needed link between router and service #10262
base: v2.11
Are you sure you want to change the base?
Conversation
56c9695
to
74f0fb4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In 90% of the cases, an explicit service label is useless.
It's better to add one example of an explicit definition instead of modifying all the current examples.
@ldez @bluepuma77 @mmatur With ceed9c5, I tried to improve the wording and keep current "magic" example. I also added a complete example in service definition section. |
Hello @mloiseleur, Could you please rebase this pull request on branch v2.11? |
ceed9c5
to
db350ad
Compare
Hello @kevinpollet , PR has been rebased. |
676c8d7
to
9fa5afa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What does this PR do?
It improve the situation described in #10258 by:
Motivation
Improve UserXP without breaking change, since many users faced it in the last four years. Detailed in #10258.
More
Additional Notes
This PR aims to improve User XP with the current behavior of Docker provider.
Introducing a new Convention over configuration (aka magic) way for configuring Traefik Proxy is not the purpose of this PR.
=> This PR does not supersede #10252.
Thanks to @joshka and @bluepuma77 who can be credited for my motivation on this PR.