-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add redis rate limiter #10211
base: master
Are you sure you want to change the base?
Add redis rate limiter #10211
Conversation
a2239f8
to
554bc3d
Compare
554bc3d
to
d28b660
Compare
Thanks for opening this PR 😃 As you can see, your PR has been marked with the |
From a UX point of view, I'm worried about the GCRA algorithm used in If we don't want to confuse people, which is already a subject difficult to explain and document, I think we should try to |
Hello @longquan0104, Thank you for your for this contribution. Regrettably, due to our current focus on v2.11 and the imminent release of v3.0, the review of your pull request will experience a delay. Additionally, as mentioned in previous comments, there are outstanding questions related to the proposed changes. It would have been beneficial to address these in a discussion on a proposal issue before the pull request, ensuring clarity and coherence. We appreciate your understanding and patience during this time. Your contribution is valued, and we look forward to working together to address the questions and integrate your feature into an upcoming release. |
cbe405e
to
f9c17e2
Compare
Sorry for disappearing for a month. I came back and made some updates for this. |
f9c17e2
to
66a6deb
Compare
update workflow
3763141
to
339cfcf
Compare
2b9d28d
to
232ee15
Compare
Hi @jspdown , I've just made an update, please help me to review it. Thank you ❤️ |
733f275
to
e438208
Compare
Please let me know if any updates need to be done @jspdown. |
7bf00a6
to
388049c
Compare
388049c
to
6ffdc41
Compare
Hello @jspdown , just make some updates. Please let me know if there is any change I should make. Thank you |
You don't have to rebase or "merge with master" your PR unless you have conflicts. |
Oops. Sorry for this mess. |
What does this PR do?
The rate limiter middleware currently is not used with Redis. From my very narrow knowledge, other systems usually use Redis for rate-limiting features. So I tried to add this. The config for the Redis may be referenced here
Motivation
More
Additional Notes
#6042