Core Scheduler Logic Port to HSM framework #6140
Open
+1,118
−365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…port # Conflicts: # components/scheduler/executors.go
…port # Conflicts: # components/scheduler/executors.go
dnr
reviewed
Jun 18, 2024
…port # Conflicts: # api/enums/v1/common.pb.go # components/scheduler/executors_test.go # components/scheduler/tasks.go
…o scheduler-port # Conflicts: # components/scheduler/statemachine.go
bergundy
reviewed
Jun 22, 2024
Co-authored-by: Roey Berman <[email protected]>
Co-authored-by: Roey Berman <[email protected]>
bergundy
reviewed
Jun 25, 2024
| return err | ||
| } | ||
| // Copy outside scheduler, which has been updated, to the state machine | ||
| *sPtr = s |
There was a problem hiding this comment.
What if there's concurrent access to this machine? You'll lose that progress.
There was a problem hiding this comment.
Does env not check this automatically?
Either way, I added a simple check for whether the state has changed since last updated. We should probably chat about whether this is something we want to build into the framework instead of relying on users .
components/scheduler/executors.go
Outdated
| tag.NewAnyTag("overlap-policy", overlapPolicy), tag.NewBoolTag("manual", manual)) | ||
| tweakables := e.config.Tweakables() | ||
|
|
||
| if s.cspec == nil { |
There was a problem hiding this comment.
You assign the spec or error out so it should never reach this point without a valid spec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Building on #6065, this PR introduces the bulk of scheduler logic to the HSM-based prototype. This makes the prototype able to correctly start workflows according to a schedule, but does not yet port the original long-polling logic. The plan is to replace long-polling with HSM-based callbacks in the subsequent PR. HSM also makes most of the side-effects or activities based logic in the original scheduler obsolete.
Why?
#6065
How did you test it?
Unit tests & Functional Tests
Potential risks
#6065
Documentation
None
Is hotfix candidate?
No