Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nsis): delete app data button gone on higher scaling #10106

Merged

Conversation

Legend-Master
Copy link
Contributor

@Legend-Master Legend-Master commented Jun 23, 2024

Fix a regression after we enabled dpi awareness for NSIS installer in #8940

On 150% scaling

Before:

image

After:

image

Also added dpiAwareness PerMonitorV2 to manifest for Windows 10 1607+ (note this should not affect lower versions since they should be able to ignore this and pick up dpiAware true set by ManifestDPIAware true)

https://github.com/kichik/nsis/blob/5fc0b87b819a9eec006df4967d08e522ddd651c9/Docs/src/attributes.but#L286-L300

@Legend-Master Legend-Master requested a review from a team as a code owner June 23, 2024 08:03
@amrbashir amrbashir merged commit 35110db into tauri-apps:dev Jun 26, 2024
14 checks passed
@Legend-Master Legend-Master deleted the nsis-uninstall-delete-data-dpi branch June 26, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants