Added changes from @nicolashenry out of #9248 #9996
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This Pull Request should solve problems with
window.opener
not being available in some edge-cases when theoauth2-redirect.html
is used with an external auth provider.Motivation and Context
In the comments of #9248 there was a proper successor to solve the the original problem.
The functionality started breaking when browsers introduced
rel=noopener
fortarget=_blank
links.The reasons why it breaks in some setups is described in #8315.
closes #8030
closes #8315
How Has This Been Tested?
I did not test it yet but others did in #9248.
Checklist
My PR contains...
src/
is unmodified: changes to documentation, CI, metadata, etc.)package.json
)My changes...
Documentation
Automated tests