Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/fix operation summary responsiveness #9982

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

klm-turing
Copy link

@klm-turing klm-turing commented May 28, 2024

Make the Swagger operation summary component responsive and smooth

Description

This PR does the following:

Ensure that the “copy” button is displayed correctly, smoothly, efficiently and does not shrink the texts of the other elements.
Ensure that the operation method is correctly positioned so that the texts of the other elements are legible.
Remove wrong styles in the operation summary container.

Motivation and Context

Resolves #8940 and potentially closes #9980

How Has This Been Tested?

I tested these style changes with different screen sizes and make sure that all existing tests pass.

Screenshots (if appropriate):

Operation summary before changes

operation_summary_before.mp4

Operation summary after changes

operation_summary_after.mp4

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

- Make sure that the text elements of the operation summary are always visible and do not shrink when the copy icon appears, whatever the screen size and whatever the length of the text.
@klm-turing
Copy link
Author

@char0n Thanks for taking a look. This one addresses summary operation responsiveness

I'll be submitting other small PR addressing the issue piece by piece as you suggest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI css scrambled Compensate Operation content in lower resolution sizes
1 participant