Update healthchecks for all containers #27316
Open
+10
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have read the CONTRIBUTING.md file.
YES
What kind of change does this PR introduce?
Fix/Feature
What is the current behavior?
Current healthchecks are run through localhost or not using docker's networking which can result in failing checks
Studio, in particular, fails healthchecks by default as it does not expose the running app over localhost.
A few issues exist regarding this, one recent example is #27312
What is the new behavior?
This PR adds a healthcheck that retrieves the IP of the container (as
curl
andwget
are not available so the container name cannot be used).For all other containers, their internal name is used for Docker to resolve their respective addresses.
Additional context
The current image for
studio
would need to be updated as this introduces adocker-healthcheck.js
file that will only be included in subsequent builds.