-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update Github OAuth step #27293
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
No changes detected in Branching Preview Branches by Supabase. |
@@ -41,7 +41,7 @@ Go to the [GitHub Developer Settings](https://github.com/settings/developers) pa | |||
- In `Application name`, type the name of your app. | |||
- In `Homepage URL`, type the full URL to your app's website. | |||
- In `Authorization callback URL`, type the callback URL of your app. | |||
- Enter the URL in the `Valid OAuth Redirect URIs` box. | |||
- Leave `Enable Device Flow` unchecked. | |||
- Click `Save Changes` at the bottom right. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PLyn I also tried going through registering a new OAuth application on GitHub and don't see the "Save changes" button at the bottom right. Should we also remove that line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, that is a good idea. I skipped over that last step and didn't realize.
Will update this in a few hours when I am back at my system.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I have read the CONTRIBUTING.md file.
YES
What kind of change does this PR introduce?
docs update - https://supabase.com/docs/guides/auth/social-login/auth-github
What is the current behavior?
Remove step - "Enter the URL in the Valid OAuth Redirect URIs box."
What is the new behavior?
Replace step with - "Leave
Enable Device Flow
unchecked."Additional context
Update steps to add Github OAuth app to match new form layout