Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update Github OAuth step #27293

Merged
merged 3 commits into from
Jun 24, 2024
Merged

docs: update Github OAuth step #27293

merged 3 commits into from
Jun 24, 2024

Conversation

PLyn
Copy link
Contributor

@PLyn PLyn commented Jun 16, 2024

I have read the CONTRIBUTING.md file.

YES

What kind of change does this PR introduce?

docs update - https://supabase.com/docs/guides/auth/social-login/auth-github

What is the current behavior?

Remove step - "Enter the URL in the Valid OAuth Redirect URIs box."

What is the new behavior?

Replace step with - "Leave Enable Device Flow unchecked."

Additional context

Update steps to add Github OAuth app to match new form layout

Copy link

vercel bot commented Jun 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 24, 2024 4:03pm
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 24, 2024 4:03pm
studio-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 24, 2024 4:03pm
zone-www-dot-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 24, 2024 4:03pm
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
studio ⬜️ Ignored (Inspect) Visit Preview Jun 24, 2024 4:03pm
studio-self-hosted ⬜️ Ignored (Inspect) Visit Preview Jun 24, 2024 4:03pm

Copy link

supabase bot commented Jun 16, 2024

No changes detected in supabase directory.
This pull request has been ignored for the connected project xguihxuzqibwxjnimxev due to its connection settings.
Go to Project Integrations Settings ↗︎ in order to change this behavior.


Branching Preview Branches by Supabase.
Learn more about Supabase for Git ↗︎.

@@ -41,7 +41,7 @@ Go to the [GitHub Developer Settings](https://github.com/settings/developers) pa
- In `Application name`, type the name of your app.
- In `Homepage URL`, type the full URL to your app's website.
- In `Authorization callback URL`, type the callback URL of your app.
- Enter the URL in the `Valid OAuth Redirect URIs` box.
- Leave `Enable Device Flow` unchecked.
- Click `Save Changes` at the bottom right.
Copy link
Contributor

@fsansalvadore fsansalvadore Jun 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PLyn I also tried going through registering a new OAuth application on GitHub and don't see the "Save changes" button at the bottom right. Should we also remove that line?

Copy link
Contributor Author

@PLyn PLyn Jun 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that is a good idea. I skipped over that last step and didn't realize.

Will update this in a few hours when I am back at my system.

@PLyn PLyn requested a review from fsansalvadore June 24, 2024 15:11
Copy link
Contributor

@fsansalvadore fsansalvadore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PLyn PLyn merged commit ad6bd52 into master Jun 24, 2024
13 checks passed
@PLyn PLyn deleted the plyn-github-oauth-doc branch June 24, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants