Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: studio - example project tabs #27262

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Hallidayo
Copy link
Contributor

I have read the CONTRIBUTING.md file.

YES

What kind of change does this PR introduce?

Supabase Studio Dashboard - Example projects

What is the current behavior?

Currently the examples on the project dashboard are a mix of both web and mobile frameworks:

Screenshot 2024-06-13 at 22 20 17

What is the new behavior?

Tabs have been added to make it easier to view app and mobile frameworks:

Screen.Recording.2024-06-13.at.22.19.55.mov

Also I've added Flutter and Swift examples.

Additional context

@supabase/frontend - what are your thoughts on this?

@Hallidayo Hallidayo requested a review from a team as a code owner June 13, 2024 21:24
Copy link

vercel bot commented Jun 13, 2024

@Hallidayo is attempting to deploy a commit to the Supabase Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Jun 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
studio-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 14, 2024 5:38am
zone-www-dot-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 14, 2024 5:38am
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
design-system ⬜️ Ignored (Inspect) Visit Preview Jun 14, 2024 5:38am
docs ⬜️ Ignored (Inspect) Visit Preview Jun 14, 2024 5:38am
studio ⬜️ Ignored (Inspect) Visit Preview Jun 14, 2024 5:38am
studio-self-hosted ⬜️ Ignored (Inspect) Visit Preview Jun 14, 2024 5:38am

@MildTomato
Copy link
Contributor

hey @Hallidayo 👋

some feedback:

  1. Could try and keep everything aligned.
Screenshot 2024-06-14 at 1 51 48 PM
  1. Use correct imports
import { Tabs_shadcn_, TabsContent_shadcn_, TabsList_shadcn_, TabsTrigger_shadcn_  } from 'ui'

this will help us with 'find and replace' code later when we remove the old Tabs components.

  1. Maybe try not stretching the TabsList across the whole width. Just use the standard size?
Screenshot 2024-06-14 at 1 53 53 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants