-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use new tax id endpoints #27246
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Ignored Deployments
|
No changes detected in Branching Preview Branches by Supabase. |
Small issue found:
Other than that all else works fine, tested:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only comments
<Form_Shadcn_ {...form}> | ||
<form |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These could be outside of <Panel/>
so that that submit <Button />
in <FormActions />
can then be inside the form, and onSubmit on form can handle the submission. but no biggie.
apps/studio/components/interfaces/Organization/BillingSettings/TaxID/TaxID.tsx
Outdated
Show resolved
Hide resolved
All lgtm! Tested previous bug found is now resolved, along with all the things that were previously tested too |
Adapts the tax id view to the new MGMT-API endpoints. Users can now only manage a single tax id instead of adding multiple.
Besides
Tax id can be managed on the organization billing page.