Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use new tax id endpoints #27246

Merged
merged 7 commits into from
Jun 19, 2024
Merged

chore: use new tax id endpoints #27246

merged 7 commits into from
Jun 19, 2024

Conversation

kevcodez
Copy link
Contributor

@kevcodez kevcodez commented Jun 13, 2024

Adapts the tax id view to the new MGMT-API endpoints. Users can now only manage a single tax id instead of adding multiple.

Besides

  • Use non-deprecated fetchers
  • Use Shadcn components

Tax id can be managed on the organization billing page.

@kevcodez kevcodez requested a review from a team as a code owner June 13, 2024 11:36
Copy link

vercel bot commented Jun 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
database-new ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2024 4:03am
studio-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2024 4:03am
5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
design-system ⬜️ Ignored (Inspect) Visit Preview Jun 19, 2024 4:03am
docs ⬜️ Ignored (Inspect) Visit Preview Jun 19, 2024 4:03am
studio ⬜️ Ignored (Inspect) Visit Preview Jun 19, 2024 4:03am
studio-self-hosted ⬜️ Ignored (Inspect) Visit Preview Jun 19, 2024 4:03am
zone-www-dot-com ⬜️ Ignored (Inspect) Visit Preview Jun 19, 2024 4:03am

Copy link

supabase bot commented Jun 13, 2024

No changes detected in supabase directory.
This pull request has been ignored for the connected project xguihxuzqibwxjnimxev due to its connection settings.
Go to Project Integrations Settings ↗︎ in order to change this behavior.


Branching Preview Branches by Supabase.
Learn more about Supabase for Git ↗︎.

@joshenlim
Copy link
Member

Small issue found:

  • Click “X” to remove (client side) existing tax id
  • Click cancel
  • What was removed did not get reinstated

Other than that all else works fine, tested:

  • Saving tax ID from none
  • Updating tax ID from one to another
  • Removing a tax ID

Copy link
Contributor

@MildTomato MildTomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only comments

Comment on lines +172 to +173
<Form_Shadcn_ {...form}>
<form
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These could be outside of <Panel/> so that that submit <Button /> in <FormActions /> can then be inside the form, and onSubmit on form can handle the submission. but no biggie.

@joshenlim
Copy link
Member

All lgtm! Tested previous bug found is now resolved, along with all the things that were previously tested too

@kevcodez kevcodez merged commit f541107 into master Jun 19, 2024
14 checks passed
@kevcodez kevcodez deleted the kevin/chore-tax-id-endpoints branch June 19, 2024 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants