refactor(docs): migrate home page to app router #27221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
|
No changes detected in Branching Preview Branches by Supabase. |
charislam
force-pushed
the
refactor/app-router-1
branch
from
f768274
to
11ad6f9
Compare
charislam
force-pushed
the
refactor/app-router-1
branch
from
11ad6f9
to
3004002
Compare
charislam
force-pushed
the
refactor/app-router-1
branch
from
3004002
to
5a7b567
Compare
charislam
force-pushed
the
refactor/app-router-1
branch
from
3184b5b
to
47b8d6f
Compare
fsansalvadore
approved these changes
Jun 17, 2024
charislam
force-pushed
the
refactor/app-router-1
branch
2 times, most recently
from
d4ccf78
to
41b00dc
Compare
charislam
force-pushed
the
refactor/app-router-1
branch
from
ca6c611
to
24dd780
Compare
|
Checked all previews. Also tested log explorer on studio to make sure URL search params still work properly there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate docs home page to App Router.
Biggest changes touching shared packages are:
Need to put
use clienton a bunch of stuffNeed to switch out for
next/compat/router(this prevents straight-out erroring if Pages Router isn't mounted, but doesn't provide a replacement for the actual functionality)Checked to make sure I haven't broken meta/OpenGraph
Checked responsive styles
Checked build size -- minor increase expected, nothing awful
Checked load time navigating between routers -- again minor increase and slight flicker expected, nothing awful
Checked for console errors -- only ones are 404s on the RSC prefetches, which are expected