feat(cli): add browser logout step #20502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
abdallahmz
force-pushed
the
feature/cloud-cli-proper-logout
branch
from
0c5c9e7
to
5c85e7b
Compare
abdallahmz
added
source: cli
abdallahmz
force-pushed
the
feature/cloud-cli-proper-logout
branch
from
5c85e7b
to
5ab96e2
Compare
Comment on lines
127
to
131
| logger.error( | ||
| "🥲 Oops! Couldn't retrieve the cloud CLI config from the server. Please try again." | ||
| ); | ||
|
|
||
| throw error; |
There was a problem hiding this comment.
wouldn't this log two errors in the user's terminal if the action is try..catching this ?
There was a problem hiding this comment.
Yes, it could output something like:
- "🥲 Oops! Couldn't retrieve the cloud CLI config from the server. Please try again."
- "Login action failed."
There was a problem hiding this comment.
Could we only have one log for UX ?
There was a problem hiding this comment.
Sure, if it's too much details for the error log level (or if we have a "one error line max per command" rule), I'll output it to debug instead
abdallahmz
force-pushed
the
feature/cloud-cli-proper-logout
branch
2 times, most recently
from
e473ff4
to
566f159
Compare
abdallahmz
added a commit
to strapi/documentation
that referenced
this pull request
Jun 24, 2024
abdallahmz
force-pushed
the
feature/cloud-cli-proper-logout
branch
from
566f159
to
0f1a5a0
Compare
abdallahmz
force-pushed
the
feature/cloud-cli-proper-logout
branch
from
0f1a5a0
to
c17aadf
Compare
was missing for staging environment. Had it in base url during local dev.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
We perform a proper OIDC logout by opening the logout endpoint in the browser. We provide the client ID and token. We do nothing if an error happens during the logout process: the logout happens at least on the app level, this just adds a logout on the Auth0 SSO level.
"chore" changes (unrelated to the initial task):
Why is it needed?
This change is needed to address the issue where users are unable to switch between different login providers. By logging out the user from the OIDC provider, the user's session is cleared. This allows the user to choose a different login provider when they attempt to log in again.
How to test it?
First, use the login command:
Log in in the CLI using one of the login providers (e.g., Google),
Then, log out (using the logout command):
The CLI should open the OIDC provider's logout URL in a browser.
Try to log in again. You should be able to choose a different login provider.