-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: put ee LICENSE in correct place #20468
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
do you want to do an experimental and we can see what was published to npm? |
Um there also is an EE folder in strapi it self.
|
Thanks, I missed that one! |
Closing this until we decide how to best handle it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr: chore
This PR contains chore tasks (cleanups, configs, tooling...)
source: tooling
Source is GitHub tooling/tests/ect
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
** Still determining the best way to handle this internally so that it doesn't happen again **
What does it do?
Includes the ee/LICENSE file
Why is it needed?
It should be there, it was missing after switching to releasing typescript dist dirs
How to test it?
npm pack
in the admin package and see that the license file now exists where it didn't beforeRelated issue(s)/PR(s)
DX-1453