-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Component unique fields #20427
Component unique fields #20427
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hey @innerdvations & @Bassel17 the WIPs are complete now so this is ready for review 🙏🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks great! Just a few small comments
tests/api/core/strapi/document-service/resources/types/contentTypes.d.ts
Outdated
Show resolved
Hide resolved
tests/api/core/strapi/document-service/resources/types/contentTypes.d.ts
Outdated
Show resolved
Hide resolved
And API tests are failing, but that may be the issue on v5/main. Once we know they're fixed we can run them again. |
What does it do?
Re implements component unique fields in V5
According to the logic:
Why is it needed?
Fix existing V4 bugs and implement core v5 functionality
How to test it?
API tests
E2E tests
Related issue(s)/PR(s)
DX-1348
WIP
closes #12541
closes #12248
closes #10107
closes #17604
closes #16918