Handle non-localized content-types in discard-draft migration #20422
Conversation
Convly
added
pr: fix
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
packages/core/core/src/migrations/database/5.0.0-discard-drafts.ts
Outdated
Show resolved
Hide resolved
| const isLocalized = strapi | ||
| .plugin('i18n') | ||
| .service('content-types') | ||
| .isLocalizedContentType(oldContentType); |
There was a problem hiding this comment.
I wasn't sure whether we wanted to target the old CT or the new one since I'm not sure about what we're trying to achieve exactly.
cc @Marc-Roig for confirmation
There was a problem hiding this comment.
I believe this should target the new one
|
You would make a PM happy by resolving this PR, it's preventing me to have a data migration done |
Even on the latest beta (14) ? |
|
@Convly yes, the issue is still there while migrating from v4 to v5 (using beta(14)) |
Wait, how is it possible to expect localized admin users, is it the wanted behavior in the new i18n implementation @Marc-Roig? |
Convly
changed the title
@Convly all content types are expected to have the locale column atm |
What does it do?
Adds a check to conditionally set locale in the
discardDraft's params.Why is it needed?
This can break app with no i18n
See #20225
How to test it?
See reproduction steps in #20225
Related issue(s)/PR(s)
fix #20225