Make generated graphql entity non optional #20419
Open
+3
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #11815
What does it do?
It makes the "EntityResponseCollection" and "id" and "attributes" key of generated graphql "Entity" non optional.
Why is it needed?
Working with typescript in Strapi is tedious because the aforementioned attributes/types are marked as optional.
The code requires a number of type assertions or optional chaining constructs to eliminate the undefined/null types leading to obscure and hard to read code.
How to test it?
In Strapi create a simple content type with two non-optional attributes, namely 'title' and 'description'.
The currently generated Schema portion looks as follows:
After applying this patch the schema will instead contain the following types:
Related issue(s)/PR(s)
#9411