feat(core): add actor ID to DoneActorEvent, ErrorActorEvent #4942
Conversation
🦋 Changeset detectedLatest commit: 8edf73b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This changes `DoneActorEvent` (`xstate.done.actor.*`) and `ErrorActorEvent` (`xstate.error.actor.*`) to have an `actorId` prop which is equal to the ID of the Actor associated with the event. Previously, this information was only available by extracting it from the `type` property of the event object using string operations.
boneskull
force-pushed
the
boneskull/actor-id-in-error-event
branch
from
fc6fee0
to
689ebb6
Compare
|
New prop is now |
packages/core/test/invoke.test.ts
Outdated
| @@ -3121,7 +3122,7 @@ describe('invoke', () => { | |||
| on: { | |||
| '*': { | |||
| actions: ({ event }) => { | |||
| actual.push(event.type); | |||
| actual.push(event as any); | |||
There was a problem hiding this comment.
we shouldn't have to cast here, what is the reporter error without it?
There was a problem hiding this comment.
This test machine does not declare its event types, so any event it handles will be of type AnyEventObject.
actual is DoneActorEvent<void>[], so we need a type assertion here. We could cast to DoneActorEvent<void>, but that seemed a little wordy. 🙂
There was a problem hiding this comment.
Previously, actual was string[], which did not need a type assertion.
use `AnyEventObject` instead of `DoneActorEvent` in `invoke.test.ts` Co-authored-by: David Khourshid <[email protected]>
|
@davidkpiano Suggestions committed |
There was a problem hiding this comment.
Just need to add a changeset (minor change: yarn changeset) 🚀
cc. @Andarist
|
@davidkpiano Is that something I should be doing? |
Yes please |
|
@davidkpiano Done. Hope I did that right. It looks like a minor bump to me |
This changes
DoneActorEvent(xstate.done.actor.*) andErrorActorEvent(xstate.error.actor.*) to have anactorIdprop which is equal to the ID of the Actor associated with the event.Previously, this information was only available by extracting it from the
typeproperty of the event object using string operations.Updated a test for
DoneActorEventto prove thatactorIdgets passed, but may want the same test for anErrorActorEvent.Ref: https://discord.com/channels/795785288994652170/1250894522616123494