Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Feature/phone and mail link #10292

Closed

Conversation

j3ll3yfi5h
Copy link
Contributor

@j3ll3yfi5h j3ll3yfi5h changed the title Feature/phone and mail link [5.x] Feature/phone and mail link Jun 13, 2024
Copy link
Member

@jasonvarga jasonvarga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've added handling for mailto links, but nothing for tel links.

When you pick phone in the option dropdown, there's no way for you to enter a value.

CleanShot 2024-06-21 at 11 37 20

When you choose the mail option, with every keystroke it adds mailto: to the start.

CleanShot 2024-06-21 at 11 34 38

Also, please disable your code formatter while you work on this so you don't end up committing unrelated changes. Thanks!

@jasonvarga jasonvarga marked this pull request as draft June 21, 2024 15:38
@jasonvarga
Copy link
Member

I'm going to close this for now to keep things organized. If/when you're ready to continue just let us know and we can reopen this.

@jasonvarga jasonvarga closed this Jun 27, 2024
@j3ll3yfi5h
Copy link
Contributor Author

FYI: I've been working with Erin on this at Flat Camp and just wanted to know if you generally welcome this PR or if it will be rejected anyway. That's why it was not fully finished.

Thanks for the feedback. As soon as I get time for it again, I'll let you know.

@jasonvarga
Copy link
Member

This PR would be welcomed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add mail and phone to link fieldtype
2 participants