Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes broken "INCLUDE/INCLUDEMANY" #494

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fixes broken "INCLUDE/INCLUDEMANY" #494

wants to merge 6 commits into from

Conversation

chrisgate
Copy link

@chrisgate chrisgate commented Jun 18, 2021 •
edited
Loading

I managed to resolved Include and includeMany in SqlKata.Execution project at QueryFactory.cs file .

Please check if there no conflict with other feature of the library?

Cheers

@ahmad-moussawi
Copy link
Contributor

@chrisgate can you elaborate more on this?

@chrisgate
Copy link
Author

Thanks for your time,
I opened this issue #433 long time ago and I found out many talk about it on different issues too.
So, I clone and resolve it on my end and it is working again.
But I am using PostgreSQL and I don't know if it will work with other compiler too but I think it should because all I edited was in this file QueryFactory.cs on SqlKata.Execution section.

Thanks

@chrisgate
Copy link
Author

Plus this my first pull request ever................at least I broke the York....lol

@chrisgate
Copy link
Author

@ahmad-moussawi

@bsekin-jb bsekin-jb mentioned this pull request Dec 6, 2022
Open
@bsekin-jb
Copy link

it fixes also #311 @ahmad-moussawi

@andrewweitzer
Copy link

@ahmad-moussawi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chrisgate @ahmad-moussawi @bsekin-jb @andrewweitzer