Fixes issue #175 (possible exception with custom managers hiding som… #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JirkaV
changed the title
JirkaV
changed the title
klplentific
reviewed
Dec 7, 2021
| @@ -68,7 +68,7 @@ def pre_save(sender, instance, raw, using, update_fields, **kwargs): | |||
|
|
|||
| # created or updated? | |||
| if not created: | |||
| old_model = sender.objects.get(pk=instance.pk) | |||
| old_model = sender._default_manager.get(pk=instance.pk) | |||
There was a problem hiding this comment.
https://docs.djangoproject.com/en/4.0/topics/db/managers/#default-managers-1, https://docs.djangoproject.com/en/4.0/topics/db/managers/#base-managers
can someone verify the most correct solution?
jheld
requested changes
May 24, 2022
| @@ -68,7 +68,7 @@ def pre_save(sender, instance, raw, using, update_fields, **kwargs): | |||
|
|
|||
| # created or updated? | |||
| if not created: | |||
| old_model = sender.objects.get(pk=instance.pk) | |||
| old_model = sender._default_manager.get(pk=instance.pk) | |||
There was a problem hiding this comment.
https://docs.djangoproject.com/en/4.0/topics/db/managers/#default-managers-1, https://docs.djangoproject.com/en/4.0/topics/db/managers/#base-managers
can someone verify the most correct solution?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As promised - use Django
_default_managerto prevent exceptions when custom manager excludes certain model instances.