Treat present? as a special method that guarantees the receiver is not nil
#1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtsmfm
commented
May 20, 2024
Comment on lines
+303
to
+325
| when AST::Types::Logic::ReceiverIsNotNil | ||
| if receiver && arguments.size.zero? | ||
| receiver_type = typing.type_of(node: receiver) | ||
| unwrap = factory.unwrap_optional(receiver_type) | ||
| truthy_receiver = unwrap || receiver_type | ||
| falsy_receiver = AST::Builtin.nil_type | ||
|
|
||
| truthy_env, falsy_env = refine_node_type( | ||
| env: env, | ||
| node: receiver, | ||
| truthy_type: truthy_receiver, | ||
| falsy_type: falsy_receiver | ||
| ) | ||
|
|
||
| truthy_result = Result.new(type: TRUE, env: truthy_env, unreachable: false) | ||
| truthy_result.unreachable! unless unwrap | ||
|
|
||
| falsy_result = Result.new(type: FALSE, env: falsy_env, unreachable: false) | ||
| falsy_result.unreachable! if no_subtyping?(sub_type: AST::Builtin.nil_type, super_type: receiver_type) | ||
|
|
||
| [truthy_result, falsy_result] | ||
| end | ||
|
|
There was a problem hiding this comment.
This part would be the exactly the same as https://github.com/soutaro/steep/pull/905/files#diff-56dab2e481abd1ca9efdcfd898234599b5f7ad222e557cf242db1d3c6904516a
@tk0miya Could you extract this part as different PR?
In either way we need this patch.
|
Thank you for opening this PR. I think there are two things to consider:
|
|
Do we need |
|
We can support these non-Ruby methods by extending RBS types where we can directly write something like: def present?: () -> self is not blank |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #472
The pull request #905 attempts to resolve the issue using annotations, but this PR resolves it by treating
present?as a special method, similar to how Sorbet handles it https://github.com/sorbet/sorbet/blob/718bc64f895abeeff88f56efbc92a3554ffaa4f2/infer/environment.cc#L564-L579