Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow deploying other GatewayClasses #9631

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

stevenctl
Copy link
Contributor

@stevenctl stevenctl commented Jun 17, 2024

Description

Allows configuring the our gateway controller to deploy gateways with additional classes.
Reduced-scope version of #9471

API changes

The only API is an internal Go API to allow GME to take control of the Gateway translation.

// bootstrap opts
ExtraGatewayClasses []string

Code Changes

The translator will now ignore other non gloo-gateway gateways (separate translation should be added for them, this PR just allows these classes to be deployed)

Also, fixed an issue where not fully specifying pull-policy breaks the deployer

{"controller": "gateway", "controllerGroup": "gateway.networking.k8s.io", "controllerKind": "Gateway", "Gateway": {"name":"gw-clsname","namespace":"default"}, "namespace": "default", "name": "gw-clsname", "reconcileID": "29e3d9fe-2821-424c-a4b0-1ee4f2d855db", "error": "failed to apply object apps/v1, Kind=Deployment gloo-proxy-gw-clsname: Deployment.apps \"gloo-proxy-gw-clsname\" is invalid: spec.template.spec.containers[0].imagePullPolicy: Unsupported value: \"Unspecified\": supported values: \"Always\", \"IfNotPresent\", \"Never\""}
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@stevenctl stevenctl changed the title k8s gateway extensions: allow customizing translator allow deploying other GatewayClasses Jun 17, 2024
@stevenctl stevenctl force-pushed the stevenctl/allow-deploying-custom-gwclass branch 2 times, most recently from 6c0ff38 to 2f1ed5a Compare June 17, 2024 17:07
@stevenctl stevenctl marked this pull request as ready for review June 17, 2024 17:07
@stevenctl stevenctl force-pushed the stevenctl/allow-deploying-custom-gwclass branch from 2f1ed5a to 16264a9 Compare June 17, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant