docker: apt-get settings to be more robust against bad mirrors #9616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
keep pr updated
|
Visit the preview URL for this PR (updated for commit 121ec6c): https://gloo-edge--pr9616-fix-apt-get-flakes-9gfi9jfp.web.app (expires Thu, 04 Jul 2024 17:48:21 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 77c2b86e287749579b7ff9cadb81e099042ef677 |
|
What's the plan for this PR? There have been 19 commits since the last change, should we remove the 'keep pr updated' label? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
apt-get is used in several place within our code base.
Today we do not choose a mirror that is particularly fast. This means that when a distro changes to a different source location such as focal now pulling from archive.ubuntu.com we are at risk for the slow connections. In order to not timeout mid build and fail what ever pipeline we are in try setting some larger resiliency guard rails as well as set some basic common sense checks against installing unneeded packages.