Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make channel optional on UploadFileV2 #1293

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

0xdeafcafe
Copy link

Pull Request Guidelines

These are recommendations for pull requests.
They are strictly guidelines to help manage expectations.

PR preparation

Run make pr-prep from the root of the repository to run formatting, linting and tests.

Should this be an issue instead
  • is it a convenience method? (no new functionality, streamlines some use case)
  • exposes a previously private type, const, method, etc.
  • is it application specific (caching, retry logic, rate limiting, etc)
  • is it performance related.
API changes

Since API changes have to be maintained they undergo a more detailed review and are more likely to require changes.

This change is non-breaking, and will allow users to upload files using the new v2 endpoint that don't have channel id, so they won't automatically be posted. This is supported by Slack and needed if users want to attach the files to a post vs have them posted in the same thread/channel later.

Examples of API changes that do not meet guidelines:

None.

@0xdeafcafe 0xdeafcafe changed the title chore: make channel optional on UploadFIleV2 chore: make channel optional on UploadFileV2 Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant