Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make UpdateUserGroupMembers arguments to be more consistent #1173

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

painhardcore
Copy link

@painhardcore painhardcore commented Feb 16, 2023

Change is pretty simple and needed to make flow more straightforward
Get members from group --> Update group with members
Get slice --> send slice
closes #1172

@painhardcore painhardcore marked this pull request as ready for review February 16, 2023 22:19
@johanmcos
Copy link
Contributor

I'm not a maintainer, but I think if you want any chance of this being accepted, you're going to need to figure out how to make your change backwards-compatible.

Perhaps you could use a variadic function argument for members

@karnikg
Copy link

karnikg commented Jan 5, 2024

This perhaps is not a needed/relevant change? I looked at forking the repo to make this change, and realized from the documentation that the actual API needs a comma separated string

A comma separated string of encoded user IDs that represent the entire list of users for the user group.

https://api.slack.com/methods/usergroups.users.update
Passing a comma separated string instead seemed to work just fine for me (instead of a list)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change UpdateUserGroupMembers to accept slice of group members
4 participants