-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[k8s] suppress connection error warnings when disconnected from k8s #3674
base: master
Are you sure you want to change the base?
Conversation
format set urllib3 log level set to ERROR level
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @asaiacai! This looks good to me. I will let @romilbhardwaj to do a final check. : )
Co-authored-by: Zhanghao Wu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @asaiacai!
@romilbhardwaj edited so the top level kubernetes APIs are all wrapped in a logging context. I've attached some example commands and outputs after disconnecting here including |
suppresses
urllib3
warnings forsky show-gpus
if k8s cluster gets disconnected. Closes #3591before changes
after changes
Tested (run the relevant ones):
bash format.sh
To create a disconnected cluster I (un)installed via k3s on a GCE VM