Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add menu item to relaunch Caprine #1410

Merged
merged 4 commits into from
Oct 18, 2020
Merged

Add menu item to relaunch Caprine #1410

merged 4 commits into from
Oct 18, 2020

Conversation

kwongtn
Copy link
Contributor

@kwongtn kwongtn commented Sep 12, 2020

As per issues mentioned in
#1321 (comment)
#1244

Caprine uses quite a lot of RAM on extended usage, the best way to reclaim RAM is to close and relaunch Caprine.
To relaunch, we had to:
Close Caprine -> Go to taskbar and close caprine again -> Open Caprine

This patch introduces the option to do so directly from the "file" menu, making relaunching a simple click away.

As per issues mentioned in 
#1321 (comment)
#1244

Caprine uses quite a lot of RAM on extended usage, the best way to reclaim RAM is to close and relaunch Caprine.
To relaunch, we had to:
Close Caprine -> Go to taskbar and close caprine again -> Open Caprine

This patch introduces the option to do so directly from the "file" menu, making relaunching a simple click away.
Silly of me to not double check and remove trailing commas...
Bad on my side, sorry 😅
source/menu.ts Outdated Show resolved Hide resolved
source/menu.ts Outdated Show resolved Hide resolved
Rebase to use latest commit
Moved code implementation from `switchitems` to respective menu creation templates
@kwongtn
Copy link
Contributor Author

kwongtn commented Sep 30, 2020

Hi @sindresorhus
I've done the changes accordingly, please check 😅

Sorry if this is wrong again -- I'm really very new to ts and electron 😂

@sindresorhus sindresorhus changed the title Relaunch app action in File menu Add menu item to relaunch Caprine Oct 18, 2020
@sindresorhus sindresorhus merged commit a312084 into sindresorhus:master Oct 18, 2020
@kwongtn kwongtn deleted the patch-1 branch October 19, 2020 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants